Skip to content

fix(cdk/drag-drop): avoid retaining destroyed items until next drag #30514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix(cdk/drag-drop): avoid retaining destroyed items until next drag #30514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/cdk/drag-drop/directives/drop-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ export class CdkDropList<T = any> implements OnDestroy {
addItem(item: CdkDrag): void {
this._unsortedItems.add(item);

// Only sync the items while dragging since this method is
// called when items are being initialized one-by-one.
if (this._dropListRef.isDragging()) {
this._syncItemsWithRef();
}
Expand All @@ -228,9 +230,8 @@ export class CdkDropList<T = any> implements OnDestroy {
removeItem(item: CdkDrag): void {
this._unsortedItems.delete(item);

if (this._dropListRef.isDragging()) {
this._syncItemsWithRef();
}
// This method might be called on destroy so we always want to sync with the ref.
this._syncItemsWithRef();
}

/** Gets the registered items in the list, sorted by their position in the DOM. */
Expand Down
Loading