Skip to content

build: remove iOS test runs #30156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

build: remove iOS test runs #30156

merged 1 commit into from
Dec 10, 2024

Conversation

crisbeto
Copy link
Member

Removes the tests that run against iOS. There are a couple of reasons to do so:

  • The tests haven't caught any issues in years.
  • The tests tend to be flaky.
  • They're running aginst iOS 15 which Angular no longer supports. We can't update to anything newer, because we would have to update our Saucelabs setup which will require dev infra time investment.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 10, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 10, 2024
Removes the tests that run against iOS. There are a couple of reasons to do so:
* The tests haven't caught any issues in years.
* The tests tend to be flaky.
* They're running aginst iOS 15 which Angular no longer supports. We can't update to anything newer, because we would have to update our Saucelabs setup which will require dev infra time investment.
@crisbeto crisbeto marked this pull request as ready for review December 10, 2024 09:43
@crisbeto crisbeto requested review from a team as code owners December 10, 2024 09:43
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team December 10, 2024 09:43
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dev-infra

@andrewseguin should sign off on this as well

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Dec 10, 2024
@andrewseguin andrewseguin removed the request for review from amysorto December 10, 2024 16:58
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Dec 10, 2024
@andrewseguin andrewseguin merged commit e935d0b into angular:main Dec 10, 2024
23 of 25 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants