fix(material/autocomplete): typos and unresolved variables in tests #29532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnlrbz
requested review from
crisbeto and
mmalerba
and removed request for
a team
dnlrbz
commented
Aug 1, 2024
| @@ -4212,7 +4212,7 @@ class AutocompleteWithoutPanel { | |||
|
|
|||
| <mat-autocomplete #auto="matAutocomplete"> | |||
| @for (group of stateGroups; track group) { | |||
| <mat-optgroup [label]="group.label"> | |||
There was a problem hiding this comment.
label does not exist in group. There is a title instead.
dnlrbz
force-pushed
the
refact/fix-typos-and-unresolved-vars
branch
from
06c660a to
be28df7
Compare
dnlrbz
changed the title
dnlrbz
force-pushed
the
refact/fix-typos-and-unresolved-vars
branch
from
be28df7 to
2839a2c
Compare
dnlrbz
changed the title
dnlrbz
force-pushed
the
refact/fix-typos-and-unresolved-vars
branch
4 times, most recently
from
177c428 to
27b81af
Compare
Fix typos in comments and test description, fix query selectors and unresolved variables
dnlrbz
force-pushed
the
refact/fix-typos-and-unresolved-vars
branch
from
27b81af to
b26ef87
Compare
dnlrbz
changed the title
crisbeto
approved these changes
Aug 9, 2024
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in comments and test descriptions, fix query selectors and unresolved variables