docs(material/table): describe how to properly update MatTableDataSource #27708 #29406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a description of how to update MatTableDataSource without breaking sorting Fixes angular#27708
HermanWKeuris
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
reviewed
Jul 11, 2024
src/material/table/table.md
Outdated
| @@ -200,6 +200,8 @@ Note that if the data properties do not match the column names, or if a more com | |||
| accessor is required, then a custom `sortingDataAccessor` function can be set to override the | |||
| default data accessor on the `MatTableDataSource`. | |||
|
|
|||
| When updating the data soure asynchronously avoid doing so by reinstanciate the entire `MatTableDataSource` as this could break sorting. Rather update it through the `MatTableDataSource.data` property. | |||
There was a problem hiding this comment.
Updated with the requested copy changes
crisbeto
approved these changes
Jul 11, 2024
crisbeto
added
action: merge
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 12, 2024
…rce angular#27708 (angular#29406) * docs(material/table): describe how to properly update MatTableDataSource Added a description of how to update MatTableDataSource without breaking sorting Fixes angular#27708 * Updated copy from reinstanciate to recreating
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a description of how to update MatTableDataSource without breaking sorting
Fixes #27708