refactor(material/form-field): simplify structural styles #29400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto,
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
commented
Jul 9, 2024
| @@ -1,5 +1,5 @@ | |||
| <div class="mdc-notched-outline__leading"></div> | |||
| <div class="mdc-notched-outline__notch" #notch> | |||
| <div class="mat-mdc-notch-piece mdc-notched-outline__leading"></div> | |||
There was a problem hiding this comment.
I introduced this class since there are a bunch of styles that target these 3 elements.
crisbeto
force-pushed
the
fork-form-field
branch
2 times, most recently
from
0fee345 to
5a19aba
Compare
Reworks the form field styles to make them smaller and easier to mainta.
andrewseguin
approved these changes
Jul 10, 2024
crisbeto
added a commit
that referenced
this pull request
Jul 10, 2024
Reworks the form field styles to make them smaller and easier to mainta. (cherry picked from commit d3a95ab)
4 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the form field styles to make them smaller and easier to maintain.