Skip to content

fix(cdk/observers): logs "ResizeObserver loop limit exceeded" errors #29036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

enten
Copy link
Contributor

@enten enten commented May 11, 2024

The function loopLimitExceededErrorHandler never logs "ResizeObserver loop limit exceeded" errors because an error event (fired by a Window object) is an instance of ErrorEvent.

@enten enten force-pushed the logs-resizeobserver-loop-limit-exceeded-errors branch from 95e40f9 to 05efb57 Compare May 11, 2024 21:27
@enten enten changed the title fix(material/observers): logs "ResizeObserver loop limit exceeded" errors fix(cdk/observers): logs "ResizeObserver loop limit exceeded" errors May 11, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 13, 2024
@crisbeto crisbeto removed the request for review from andrewseguin May 13, 2024 08:22
@crisbeto crisbeto self-assigned this May 13, 2024
@crisbeto crisbeto merged commit 37958ef into angular:main May 13, 2024
26 of 28 checks passed
crisbeto pushed a commit that referenced this pull request May 13, 2024
crisbeto pushed a commit that referenced this pull request May 13, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants