fix(cdk/drag-drop): resolve incompatibility with property minification #28980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the `showPopover` call was being minified by Closure and preventing the popover from opening.
andrewseguin
approved these changes
Apr 30, 2024
|
I'm a bit surprised as well, but I checked locally that it resolves the issue. My best guess is that typings are outdated somewhere so the compiler didn't know not to minify it. |
gisbdzhch
pushed a commit
to gisktzh/gb3-web_ui
that referenced
this pull request
May 23, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | [`17.3.6` -> `17.3.7`](https://renovatebot.com/diffs/npm/@angular%2fcdk/17.3.6/17.3.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@angular/material](https://github.com/angular/components) | [`17.3.6` -> `17.3.7`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/17.3.6/17.3.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>angular/components (@​angular/cdk)</summary> ### [`v17.3.7`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1737-plastic-deer-2024-05-02) [Compare Source](angular/components@17.3.6...17.3.7) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [3c8abfb990](angular/components@3c8abfb) | fix | **drag-drop:** remove preview wrapper | | [a03a47c938](angular/components@a03a47c) | fix | **drag-drop:** reset user agent color on preview popover | | [8e3dfd2e5b](angular/components@8e3dfd2) | fix | **drag-drop:** resolve incompatibility with property minification ([#​28980](angular/components#28980)) | <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about t...
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
showPopovercall was being minified by Closure and preventing the popover from opening.