fix(multiple): remove label for attribute on non-native elements #28948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `mat-select` and `mat-date-range-picker`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`. Fixes angular#27241.
wagnermaciel
approved these changes
Apr 24, 2024
zarend
approved these changes
Apr 24, 2024
| * on the `<label>` inside the form field. Set this to true to prevent the form | ||
| * field from associating the label with non-native elements. | ||
| */ | ||
| readonly disableAutomaticLabeling?: boolean; |
There was a problem hiding this comment.
Should this have @docs-private like the other disableAutomaticLabeling?
There was a problem hiding this comment.
Nah this one is an actual public API. In the other places it's something users shouldn't touch.
crisbeto
added a commit
that referenced
this pull request
Apr 24, 2024
) Adds an option to remove the `for` attribute from the `<label>` inside the form field from elements that can't be labeled. Also applies the new option to `mat-select` and `mat-date-range-picker`. This isn't an accessibility regression, because those elements were already being labeled using `aria-labelledby`. Fixes #27241. (cherry picked from commit 94a0834)
|
Hi there, but how do you do this without getting this error: 
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to remove the
forattribute from the<label>inside the form field from elements that can't be labeled. Also applies the new option tomat-selectandmat-date-range-picker. This isn't an accessibility regression, because those elements were already being labeled usingaria-labelledby.Fixes #27241.