Skip to content

refactor(material/select): Remove use of zone onStable to wait for options #28637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba force-pushed the select-zone branch 2 times, most recently from c81362e to 3560d79 Compare February 24, 2024 01:05
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 24, 2024
@mmalerba mmalerba marked this pull request as ready for review February 24, 2024 16:55
@mmalerba mmalerba requested a review from crisbeto as a code owner February 24, 2024 16:55
@mmalerba mmalerba changed the title refactor(material/select): use afterNextRender to wait for options refactor(material/select): Remove use of onStable to wait for options Feb 26, 2024
@mmalerba mmalerba force-pushed the select-zone branch 2 times, most recently from 7b99e8a to 29a39f1 Compare February 26, 2024 21:13
@mmalerba mmalerba changed the title refactor(material/select): Remove use of onStable to wait for options refactor(material/select): Remove use of zone onStable to wait for options Feb 26, 2024
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice one.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 27, 2024
@mmalerba mmalerba merged commit 8abb33d into angular:main Feb 27, 2024
mmalerba added a commit that referenced this pull request Feb 27, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants