Skip to content

docs(material-3): fix typography config #28635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

docs(material-3): fix typography config #28635

merged 1 commit into from
Feb 28, 2024

Conversation

voi99
Copy link
Contributor

@voi99 voi99 commented Feb 23, 2024

Encountering an error with $config.typography in the provided Angular Material 3 example.

image

I believe that brand and bold should be replaced with brand-family and bold-weight .

@angular-robot angular-robot bot added the area: docs Related to the documentation label Feb 23, 2024
@voi99 voi99 marked this pull request as ready for review February 23, 2024 20:28
@voi99 voi99 requested a review from jelbourn as a code owner February 23, 2024 20:28
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 28, 2024
@crisbeto crisbeto removed the request for review from jelbourn February 28, 2024 09:00
@crisbeto crisbeto merged commit 6fc0193 into angular:main Feb 28, 2024
crisbeto pushed a commit that referenced this pull request Feb 28, 2024
@voi99 @crisbeto
docs(material-3): fix typography config (#28635)
2d8dc70 
(cherry picked from commit 6fc0193)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2024
@voi99 voi99 deleted the docs-material-3-typography-config branch June 12, 2024 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voi99 @crisbeto