Skip to content

fix(material/list): use transparent background for M3 #28504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/material-experimental/theming/_m3-tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,17 @@
@return $tokens;
}

/// Fixes values in the list tokens that are inconsistent with its usage.
/// @param {Map} $initial-tokens Map of list tokens currently being generated.
/// @return {Map} The given tokens, with the inconsistent values replaced with valid ones.
@function _fix-list-tokens($tokens) {
// This does not match the spec, which defines this to be `md.sys.color.surface`.
// However, this interferes with the use case of placing a list on other components. For example,
// the bottom sheet's container color is `md.sys.color.surface-container-low`. Instead, allow the
// list to just display the colors for its background.
@return map.set($tokens, list-item-container-color, transparent);
}

/// Generates a set of namespaced tokens for all components.
/// @param {Map} $systems The MDC system tokens
/// @param {Boolean} $include-non-systemized Whether to include non-systemized tokens
Expand Down Expand Up @@ -660,7 +671,9 @@
),
_namespace-tokens(
(mdc, list),
mdc-tokens.md-comp-list-values($systems, $exclude-hardcoded),
_fix-list-tokens(
mdc-tokens.md-comp-list-values($systems, $exclude-hardcoded)
),
$token-slots
),
_namespace-tokens(
Expand Down