Skip to content

docs(material/chips): remove instructions to announce deletion #28253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Dec 8, 2023

Update Chips a11y documentation. Remove instructions to make an announcement when deleting chips.

Remove the call to LiveAnnouncer. Remove unnecessary live regions to avoid disrupting users who use Assistive Technology.

Update Chips a11y documentation. Remove instructions to make an
announcement when deleting chips.

Remove the call to LiveAnnouncer. Remove unnecessary live regions to
avoid disrupting users who use Assistive Technology.
@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: material/chips area: docs Related to the documentation labels Dec 8, 2023
@zarend zarend requested a review from jelbourn December 8, 2023 23:58
@zarend
Copy link
Contributor Author

zarend commented Dec 8, 2023

Googlers: see related internal post.

@zarend zarend added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 9, 2023
@zarend zarend added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 19, 2024
@zarend zarend merged commit 47819c4 into angular:main Jan 19, 2024
zarend added a commit that referenced this pull request Jan 19, 2024
Update Chips a11y documentation. Remove instructions to make an
announcement when deleting chips.

Remove the call to LiveAnnouncer. Remove unnecessary live regions to
avoid disrupting users who use Assistive Technology.

(cherry picked from commit 47819c4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants