Skip to content

fix(material/slider): fix value indicator bubble for m3 #28250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2023
Merged

fix(material/slider): fix value indicator bubble for m3 #28250

merged 3 commits into from
Dec 14, 2023

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

mmalerba
mmalerba reviewed Dec 8, 2023
View reviewed changes
@mmalerba mmalerba added dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release labels Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

Deployed dev-app for 41504b5 to: https://ng-dev-previews-comp--pr-angular-components-28250-dev-res2xnwq.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

mmalerba
mmalerba approved these changes Dec 8, 2023 •
edited
Loading
View reviewed changes
mmalerba
mmalerba reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 is missing styles. I think its because we only output MDC's base token values, not our custom ones: https://github.com/angular/components/blob/main/src/material/slider/_slider-theme.scss#L18 (you need a line like we have for color: https://github.com/angular/components/blob/main/src/material/slider/_slider-theme.scss#L42)

@mmalerba mmalerba self-requested a review December 8, 2023 21:58
mmalerba
mmalerba approved these changes Dec 13, 2023
View reviewed changes
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Dec 14, 2023
@wagnermaciel wagnermaciel merged commit 4550637 into angular:main Dec 14, 2023
wagnermaciel added a commit that referenced this pull request Dec 14, 2023
@wagnermaciel
fix(material/slider): fix value indicator bubble for m3 (#28250)
766d1d8 
* fix(material/slider): fix value indicator bubble for m3

* fixup! fix(material/slider): fix value indicator bubble for m3

* fixup! fix(material/slider): fix value indicator bubble for m3

(cherry picked from commit 4550637)
essjay05 pushed a commit to essjay05/angular-components that referenced this pull request Dec 14, 2023
@wagnermaciel @essjay05
fix(material/slider): fix value indicator bubble for m3 (angular#28250)
152737b 
* fix(material/slider): fix value indicator bubble for m3

* fixup! fix(material/slider): fix value indicator bubble for m3

* fixup! fix(material/slider): fix value indicator bubble for m3
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagnermaciel @mmalerba