-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(material/form-field): tokenize density overrides #28249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc28aab
to
15089ee
Compare
d8c1777
to
ecb5d18
Compare
mmalerba
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ecb5d18
to
c438224
Compare
c438224
to
8168695
Compare
Switches the custom density implementation of the form field to be based on tokens.
8168695
to
6ea3e86
Compare
crisbeto
added a commit
that referenced
this pull request
Dec 12, 2023
Switches the custom density implementation of the form field to be based on tokens. (cherry picked from commit 087cf15)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 12, 2023
…gular#28249)" This reverts commit 087cf15.
crisbeto
added a commit
that referenced
this pull request
Dec 12, 2023
crisbeto
added a commit
that referenced
this pull request
Dec 12, 2023
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 13, 2023
**Note:** this is a resubmit of angular#28249. Switches the custom density implementation of the form field to be based on tokens.
crisbeto
added a commit
that referenced
this pull request
Dec 13, 2023
**Note:** this is a resubmit of #28249. Switches the custom density implementation of the form field to be based on tokens.
crisbeto
added a commit
that referenced
this pull request
Dec 13, 2023
essjay05
pushed a commit
to essjay05/angular-components
that referenced
this pull request
Dec 14, 2023
) **Note:** this is a resubmit of angular#28249. Switches the custom density implementation of the form field to be based on tokens.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the custom density implementation of the form field to be based on tokens.