Skip to content

refactor(material/form-field): tokenize density overrides #28249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 8, 2023

Switches the custom density implementation of the form field to be based on tokens.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 8, 2023
@crisbeto crisbeto force-pushed the form-field-density-tokens branch from dc28aab to 15089ee Compare December 8, 2023 11:04
@crisbeto crisbeto marked this pull request as ready for review December 8, 2023 11:06
@crisbeto crisbeto force-pushed the form-field-density-tokens branch 2 times, most recently from d8c1777 to ecb5d18 Compare December 8, 2023 13:44
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the form-field-density-tokens branch from ecb5d18 to c438224 Compare December 9, 2023 08:40
@crisbeto crisbeto self-assigned this Dec 9, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2023
@crisbeto crisbeto force-pushed the form-field-density-tokens branch from c438224 to 8168695 Compare December 11, 2023 12:49
Switches the custom density implementation of the form field to be based on tokens.
@crisbeto crisbeto force-pushed the form-field-density-tokens branch from 8168695 to 6ea3e86 Compare December 11, 2023 13:22
@crisbeto crisbeto removed the request for review from devversion December 12, 2023 15:13
@crisbeto crisbeto merged commit 087cf15 into angular:main Dec 12, 2023
crisbeto added a commit that referenced this pull request Dec 12, 2023
Switches the custom density implementation of the form field to be based on tokens.

(cherry picked from commit 087cf15)
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 12, 2023
crisbeto added a commit that referenced this pull request Dec 12, 2023
crisbeto added a commit that referenced this pull request Dec 12, 2023
crisbeto added a commit to crisbeto/material2 that referenced this pull request Dec 13, 2023
**Note:** this is a resubmit of angular#28249.

Switches the custom density implementation of the form field to be based on tokens.
crisbeto added a commit that referenced this pull request Dec 13, 2023
**Note:** this is a resubmit of #28249.

Switches the custom density implementation of the form field to be based on tokens.
crisbeto added a commit that referenced this pull request Dec 13, 2023
**Note:** this is a resubmit of #28249.

Switches the custom density implementation of the form field to be based on tokens.

(cherry picked from commit 7e7570d)
essjay05 pushed a commit to essjay05/angular-components that referenced this pull request Dec 14, 2023
)

**Note:** this is a resubmit of angular#28249.

Switches the custom density implementation of the form field to be based on tokens.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants