ci: properly build dev-app for automatic deploy #28047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deploy script seems rather legacy and also doesn't ensure that the dist directory is actually present. We can simplify the logic and potentially delete the script in the future.
angular-robot
bot
added
the
area: build & ci
devversion
added
action: merge
crisbeto
approved these changes
Nov 2, 2023
devversion
added a commit
that referenced
this pull request
Nov 2, 2023
The deploy script seems rather legacy and also doesn't ensure that the dist directory is actually present. We can simplify the logic and potentially delete the script in the future. (cherry picked from commit ff67a41)
|
tyty for fixing this 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deploy script seems rather legacy and also doesn't ensure that the dist directory is actually present. We can simplify the logic and potentially delete the script in the future.