Skip to content

fix(cdk/tree): cleanup tree-key-manager token #28022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 30, 2023

Change how tree-key-manager token is provided. Provide default TreeKeyManager at root. Remove provider from NgModule.

@zarend zarend marked this pull request as ready for review October 30, 2023 21:26
Change how tree-key-manager token is provided. Provide default
TreeKeyManager at root. Remove provider from NgModule.
@zarend zarend force-pushed the cdk-tree-revamp-injectors branch from 53e500e to 600c6f5 Compare October 30, 2023 21:27
@zarend
Copy link
Contributor Author

zarend commented Oct 30, 2023

This PR seems to fix the CI failure in the linker_jit_tests.

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants