fix(material/theming): Fix subtle bug in current-selector-or-root #27898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Oct 4, 2023
|
@crisbeto I think if people just html {
@include mat.button-theme(...);
@include mat.checkbox-theme(...);
...
}and most importantly, the order will always remain the same as what the user put |
There was a sublte bug in the previous implementation. Consider the case:
```scss
div {
@include current-selector-or-root() {
color: red;
}
color: green;
}
```
The previous implementation lifted the `color: red;` into a separate
selector block that came *after* the initial one, resulting in the order
being flipped:
```css
div {
color: green;
}
div {
color: red;
}
```
The new code will produce the correct ordering:
```css
div {
color: red;
color: green;
}
```
zarend
pushed a commit
that referenced
this pull request
Oct 6, 2023
…7898) There was a sublte bug in the previous implementation. Consider the case: ```scss div { @include current-selector-or-root() { color: red; } color: green; } ``` The previous implementation lifted the `color: red;` into a separate selector block that came *after* the initial one, resulting in the order being flipped: ```css div { color: green; } div { color: red; } ``` The new code will produce the correct ordering: ```css div { color: red; color: green; } ```
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a sublte bug in the previous implementation. Consider the case:
The previous implementation lifted the
color: red;into a separate selector block that came after the initial one, resulting in the order being flipped:The new code will produce the correct ordering: