build: replace custom lint rule with compiler option #27833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
angular-robot
bot
added
the
area: build & ci
crisbeto
force-pushed
the
property-access-rule
branch
from
8a0eff3 to
ed8b322
Compare
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin,
mmalerba and
zarend
as code owners
devversion
approved these changes
Sep 23, 2023
We currently have a lint rule that prevents dotted access in `SimpleChanges` objects, because it will break with property minification. These changes replace the rule with the built-in `noPropertyAccessFromIndexSignature` compiler option which has the same effect with the added benefit of aligning us closer with g3 and reducing the amount of code we need to maintain.
crisbeto
force-pushed
the
property-access-rule
branch
from
ed8b322 to
5eb3fe4
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a lint rule that prevents dotted access in
SimpleChangesobjects, because it will break with property minification. These changes replace the rule with the built-innoPropertyAccessFromIndexSignaturecompiler option which has the same effect with the added benefit of aligning us closer with g3 and reducing the amount of code we need to maintain.