Skip to content

refactor(multiple): convert components to theme inspection API (round 4) #27740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 30, 2023

BREAKING CHANGE:

  • Themes are now more strictly validated when calling Angular Material theme mixins. For example, calling mat.button-typography with a theme has typography: null is now an error.
  • The mat.legacy-typography-hierarchy mixin has been removed in favor of `mat.typography-hierarchy

@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch from b4e147d to 4929b23 Compare August 30, 2023 23:17
@mmalerba mmalerba changed the title refactor(multiple): convert components to theme inspection API refactor(multiple): convert components to theme inspection API (round 4) Aug 30, 2023
@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch 3 times, most recently from 6dec78c to ee4af5b Compare August 31, 2023 00:00
@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Aug 31, 2023
@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch from ee4af5b to 46441ec Compare August 31, 2023 20:03
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Aug 31, 2023
@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch 3 times, most recently from 4bacd99 to 3a56960 Compare August 31, 2023 21:30
@mmalerba mmalerba marked this pull request as ready for review August 31, 2023 21:31
@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch 3 times, most recently from 0edc78f to f1799b5 Compare September 1, 2023 16:07
BREAKING CHANGE:
- Themes are now more strictly validated when calling Angular Material
theme mixins. For example, calling `mat.button-typography` with a theme
has `typography: null` is now an error.
- The `mat.legacy-typography-hierarchy` mixin has been removed in favor
  of `mat.typography-hierarchy`
@mmalerba mmalerba force-pushed the inspection-api-conversion-4 branch from f1799b5 to 6d9e94a Compare September 1, 2023 16:49
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 1, 2023
@mmalerba mmalerba merged commit 90465a1 into angular:main Sep 1, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants