Skip to content

Toggle aria-modal attribute in parent modal when autocomplete panel opens / closes #27663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2023
Merged

Toggle aria-modal attribute in parent modal when autocomplete panel opens / closes #27663

merged 2 commits into from
Oct 1, 2023

Conversation

eminguyen
Copy link
Contributor

No description provided.

@eminguyen eminguyen requested a review from crisbeto as a code owner August 16, 2023 20:13
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 26, 2023
@mmalerba mmalerba removed the request for review from crisbeto October 1, 2023 17:39
@mmalerba mmalerba merged commit f6c5ea4 into angular:main Oct 1, 2023
mmalerba pushed a commit that referenced this pull request Oct 1, 2023
@eminguyen @mmalerba
Toggle aria-modal attribute in parent modal when autocomplete panel o…
d62cc12 
…pens / closes (#27663)

* Toggle parent modal aria-owns attribute when autocomplete is closed

* Add unit tests and update comments

(cherry picked from commit f6c5ea4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eminguyen @mmalerba