fix(material/form-field): position outlined form field label correctl… #27525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
reviewed
Jul 27, 2023
behzadmehrabi
force-pushed
the
fix-outlined-form-field-label-offset
branch
2 times, most recently
from
932f0a7 to
3308bed
Compare
behzadmehrabi
force-pushed
the
fix-outlined-form-field-label-offset
branch
2 times, most recently
from
a9fdd9a to
d4b8e13
Compare
mmalerba
reviewed
Aug 1, 2023
behzadmehrabi
force-pushed
the
fix-outlined-form-field-label-offset
branch
3 times, most recently
from
37b4f2a to
f112392
Compare
…nd prefix content change Fixes issues with the outlined form-field label offset not updating correctly when the form-field was attached to the DOM but not visible, or when the prefix container had dynamic content.
behzadmehrabi
force-pushed
the
fix-outlined-form-field-label-offset
branch
from
f112392 to
98edad0
Compare
mmalerba
reviewed
Aug 3, 2023
mmalerba
reviewed
Aug 3, 2023
mmalerba
added
action: merge
|
Hi @behzadmehrabi, I tried running the internal tests for this and got a lot of failures because the tests were throwing |
mmalerba
added
presubmit failures
josephperrott
requested review from
crisbeto and
amysorto
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the outlined form-field label offset not updating correctly when the form-field was attached to the DOM but not visible, or when the prefix container had dynamic content.
Fixes #26332