refactor(material/toolbar): switch to tokens API #27479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
Reworks the toolbar to use the new tokens theming API.
crisbeto
requested review from
andrewseguin
and removed request for
AndrewKushnir
crisbeto
added a commit
to crisbeto/tensorboard
that referenced
this pull request
Jul 19, 2023
We're in the process of changing the Angular Material components to use CSS variables for theming. This involves moving some declarations from the theme to the component base styles which changes its specificity. One such change that breaks the Tensorboard screenshot tests is angular/components#27479. The problem boils down to the fact that because the styles that override the form field color are in the base styles now _and_ the Tensorboard dark theme targets `body.dark-mode`, only in dark mode some of the select declarations aren't being overwritten anymore. This won't be a problem once Tensorboard moves away from the legacy Angular Material components, but for now this patch is necessary to ensure that it doesn't blend into the toolbar. **Note:** these changes will require some minor updates to the existing internal screenshots. See cl/549228851 for more info.
andrewseguin
approved these changes
Jul 19, 2023
crisbeto
added a commit
to crisbeto/tensorboard
that referenced
this pull request
Jul 20, 2023
We're in the process of changing the Angular Material components to use CSS variables for theming. This involves moving some declarations from the theme to the component base styles which changes its specificity. One such change that breaks the Tensorboard screenshot tests is angular/components#27479. The problem boils down to the fact that because the styles that override the form field color are in the base styles now _and_ the Tensorboard dark theme targets `body.dark-mode`, only in dark mode some of the select declarations aren't being overwritten anymore. This won't be a problem once Tensorboard moves away from the legacy Angular Material components, but for now this patch is necessary to ensure that it doesn't blend into the toolbar. **Note:** these changes will require some minor updates to the existing internal screenshots. See cl/549228851 for more info.
bmd3k
pushed a commit
to tensorflow/tensorboard
that referenced
this pull request
Jul 20, 2023
We're in the process of changing the Angular Material components to use CSS variables for theming. This involves moving some declarations from the theme to the component base styles which changes its specificity. One such change that breaks the Tensorboard screenshot tests is angular/components#27479. The problem boils down to the fact that because the styles that override the form field color are in the base styles now _and_ the Tensorboard dark theme targets `body.dark-mode`, only in dark mode some of the select declarations aren't being overwritten anymore. This won't be a problem once Tensorboard moves away from the legacy Angular Material components, but for now this patch is necessary to ensure that it doesn't blend into the toolbar. **Note:** these changes will require some minor updates to the existing internal screenshots. See cl/549228851 for more info.
crisbeto
added a commit
that referenced
this pull request
Jul 20, 2023
Reworks the toolbar to use the new tokens theming API. (cherry picked from commit ffb2464)
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
Reworks the toolbar to use the new tokens theming API.
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
Reworks the toolbar to use the new tokens theming API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the toolbar to use the new tokens theming API.