-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(material/divider): switch to tokens API #27478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc3d271
to
8b83294
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, but I wanted to note that for the other components we try to do the token conversions within the team, because landing the changes internally often requires a lot of debugging and tweaking the CSS. The divider is simple enough that we can go with this PR though.
8b83294
to
bffcede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your welcome, I appreciate your feedback :)...I have 2 questions out of curiosity, if you don't mind.
|
|
(cherry picked from commit cc02ea8)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.