fix(material/menu): prevent menu styles from leaking to other components #27378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
force-pushed
the
menu-leaky-styles
branch
2 times, most recently
from
e77705c to
c57238c
Compare
The menu theme was including the MDC list styles directly at the root of the theme which caused to leak into other components like `mat-list`. The mixins will be removed in angular#27377, however currently the screenshot tests of a lot of internal targets assume that the leaky styles will be there which breaks the presubmit of angular#27377. These changes introduce a *temporary* wrapper class around the mixins so that the incorrect screenshots can be approved before trying to land angular#27377.
crisbeto
force-pushed
the
menu-leaky-styles
branch
from
c57238c to
a71fffa
Compare
andrewseguin
approved these changes
Jun 30, 2023
crisbeto
added a commit
that referenced
this pull request
Jun 30, 2023
…nts (#27378) The menu theme was including the MDC list styles directly at the root of the theme which caused to leak into other components like `mat-list`. The mixins will be removed in #27377, however currently the screenshot tests of a lot of internal targets assume that the leaky styles will be there which breaks the presubmit of #27377. These changes introduce a *temporary* wrapper class around the mixins so that the incorrect screenshots can be approved before trying to land #27377. (cherry picked from commit 06f8544)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 22, 2023
After angular#27377 and angular#27378 we no longer use MDC classes directly in the markup. Instead we either use our own styles or we target our selectors with MDC mixins. However, the MDC classes were left in to reduce the amount of internal breakages. These leftover styles can still cause styles to bleed in from the MDC list so this change removes any remaining references.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 22, 2023
After angular#27377 and angular#27378 we no longer use MDC classes directly in the markup. Instead we either use our own styles or we target our selectors with MDC mixins. However, the MDC classes were left in to reduce the amount of internal breakages. These leftover styles can still cause styles to bleed in from the MDC list so this change removes any remaining references.
crisbeto
added a commit
that referenced
this pull request
Jul 22, 2023
After #27377 and #27378 we no longer use MDC classes directly in the markup. Instead we either use our own styles or we target our selectors with MDC mixins. However, the MDC classes were left in to reduce the amount of internal breakages. These leftover styles can still cause styles to bleed in from the MDC list so this change removes any remaining references. (cherry picked from commit 5a7da12)
crisbeto
added a commit
that referenced
this pull request
Jul 22, 2023
After #27377 and #27378 we no longer use MDC classes directly in the markup. Instead we either use our own styles or we target our selectors with MDC mixins. However, the MDC classes were left in to reduce the amount of internal breakages. These leftover styles can still cause styles to bleed in from the MDC list so this change removes any remaining references.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu theme was including the MDC list styles directly at the root of the theme which caused to leak into other components like
mat-list.The mixins will be removed in #27377, however currently the screenshot tests of a lot of internal targets assume that the leaky styles will be there which breaks the presubmit of #27377.
These changes introduce a temporary wrapper class around the mixins so that the incorrect screenshots can be approved before trying to land #27377.