Skip to content

refactor(material/core): resolve flakes in ripple tests #27371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

crisbeto
Copy link
Member

Fixes some flakes that have shown up in the ripple tests. It seems that sometimes the browser doesn't assign the changedTouches in tests which leads to flakiness.

Fixes some flakes that have shown up in the ripple tests. It seems that sometimes the browser doesn't assign the `changedTouches` in tests which leads to flakiness.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 27, 2023
@crisbeto crisbeto requested a review from wagnermaciel June 27, 2023 07:33
@crisbeto crisbeto requested a review from devversion as a code owner June 27, 2023 07:33
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 27, 2023
@crisbeto crisbeto merged commit d7d8526 into angular:main Jun 27, 2023
crisbeto added a commit that referenced this pull request Jun 27, 2023
Fixes some flakes that have shown up in the ripple tests. It seems that sometimes the browser doesn't assign the `changedTouches` in tests which leads to flakiness.

(cherry picked from commit d7d8526)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants