Skip to content

fix(cdk/schematics): clean up deep imports of devkit APIs #27363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2023
Merged

fix(cdk/schematics): clean up deep imports of devkit APIs #27363

merged 1 commit into from
Jun 25, 2023

Conversation

crisbeto
Copy link
Member

Removes deep imports for some devkit APIs from the CDK schematics code to avoid potential build issues.

Fixes #27344.

@crisbeto
fix(cdk/schematics): clean up deep imports of devkit APIs
745770b 
Removes deep imports for some devkit APIs from the CDK schematics code to avoid potential build issues.

Fixes angular#27344.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jun 25, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2023
@crisbeto crisbeto merged commit 0d499a3 into angular:main Jun 25, 2023
crisbeto added a commit that referenced this pull request Jun 25, 2023
@crisbeto
fix(cdk/schematics): clean up deep imports of devkit APIs (#27363)
4195289 
Removes deep imports for some devkit APIs from the CDK schematics code to avoid potential build issues.

Fixes #27344.

(cherry picked from commit 0d499a3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/schematics): Cannot find module '@angular-devkit/core/src/workspace/json/reader'
2 participants
@crisbeto @devversion