fix(material/core): add validation to create-token-slot #27357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we look up if a token is set to null in the token map, and if it is, we don't emit the slot at all. The problem is that `null` is also returned if the token doesn't exist at all which may mask some bugs. These changes add a check to verify that the token exists before trying to look it up.
crisbeto
added
P3
devversion
approved these changes
Jun 24, 2023
crisbeto
added a commit
that referenced
this pull request
Jun 25, 2023
Currently we look up if a token is set to null in the token map, and if it is, we don't emit the slot at all. The problem is that `null` is also returned if the token doesn't exist at all which may mask some bugs. These changes add a check to verify that the token exists before trying to look it up. (cherry picked from commit 425c469)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we look up if a token is set to null in the token map, and if it is, we don't emit the slot at all. The problem is that
nullis also returned if the token doesn't exist at all which may mask some bugs.These changes add a check to verify that the token exists before trying to look it up.