Skip to content

docs(material/chips): require communicating to AT how to edit a chip #27336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2023
Merged

docs(material/chips): require communicating to AT how to edit a chip #27336

merged 1 commit into from
Jul 6, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jun 20, 2023

Update the accessibility section of chips component to adress editable chips. Require developer to communicate to AT how to edit a chip using a keyboard.

Relates to issue #27106.

@zarend
docs(material/chips): require communicating to AT how to edit a chip
5c5f2ef 
Update the accessibility section of chips component to adress editable
chips. Require developer to communicate to AT how to edit a chip using a
keyboard.

Relates to issue angular#27106.
@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation target: patch This PR is targeted for the next patch release area: material/chips labels Jun 20, 2023
@zarend zarend requested a review from jelbourn June 20, 2023 19:26
@zarend zarend requested review from mmalerba and crisbeto as code owners June 20, 2023 19:26
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 20, 2023
mmalerba
mmalerba approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jul 6, 2023
@zarend zarend merged commit a320042 into angular:main Jul 6, 2023
zarend added a commit that referenced this pull request Jul 6, 2023
@zarend
docs(material/chips): require communicating to AT how to edit a chip (#…
42ceec2 
…27336)

Update the accessibility section of chips component to adress editable
chips. Require developer to communicate to AT how to edit a chip using a
keyboard.

Relates to issue #27106.

(cherry picked from commit a320042)
stephenrca pushed a commit to stephenrca/components that referenced this pull request Aug 2, 2023
@zarend @stephenrca
docs(material/chips): require communicating to AT how to edit a chip (a…
d0b5002 
…ngular#27336)

Update the accessibility section of chips component to adress editable
chips. Require developer to communicate to AT how to edit a chip using a
keyboard.

Relates to issue angular#27106.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarend @crisbeto @mmalerba