fix(material/chips): remove button role from editable chips #27317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
|
Deployed dev-app for 4e2cf9c to: https://ng-dev-previews-comp--pr-angular-components-27317-9f8cfdw6.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
zarend
force-pushed
the
editable-chips-aria
branch
6 times, most recently
from
dd43095 to
b056fc2
Compare
crisbeto
reviewed
Jun 21, 2023
crisbeto
approved these changes
Jun 21, 2023
Removes the button role from editable input chips. Fix accessibility issue in ChipRow where the chip action element is mislabeled as a button (angular#27106). Remove butotn role by remove DOM node thtat used to have button role and using the gridcell role element for the primary chip action instead. Tested cross-browser with supported screen readers on MacOS and Windows. Tested on "Chips with input" example by verifying that a chip could be added then edited after adding. Also verifying that AT read the chip's aria description. Testing Environment - macOS 13.4 (22F66) / VoiceOver - Chrome Version 114.0.5735.133 (Official Build) (arm64) - Firefox 114.0.1 (64-bit) - windows 10 Enteprise Version 22H2 - JAWS VERSION 2020.2006.12 ILM - NVDA version 2022.3 - Chrome Version 114.0.5735.134 (Official Build) (64-bit) - Firefox 114.0.2 (64-bit) Fix angular#27106
zarend
force-pushed
the
editable-chips-aria
branch
from
b056fc2 to
4e2cf9c
Compare
|
I'm merging this PR since the related CL was submitted yesterday. |
crisbeto
pushed a commit
that referenced
this pull request
Jun 28, 2023
Removes the button role from editable input chips. Fix accessibility issue in ChipRow where the chip action element is mislabeled as a button (#27106). Remove butotn role by remove DOM node thtat used to have button role and using the gridcell role element for the primary chip action instead. Tested cross-browser with supported screen readers on MacOS and Windows. Tested on "Chips with input" example by verifying that a chip could be added then edited after adding. Also verifying that AT read the chip's aria description. Testing Environment - macOS 13.4 (22F66) / VoiceOver - Chrome Version 114.0.5735.133 (Official Build) (arm64) - Firefox 114.0.1 (64-bit) - windows 10 Enteprise Version 22H2 - JAWS VERSION 2020.2006.12 ILM - NVDA version 2022.3 - Chrome Version 114.0.5735.134 (Official Build) (64-bit) - Firefox 114.0.2 (64-bit) Fix #27106 (cherry picked from commit e0608cb)
|
Thanks, my bad 🤦 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(material/chips): remove button role from editable chips
Removes the button role from editable input chips. Fix accessibility
issue in ChipRow where the chip action element is mislabeled as a
button (#27106). Remove butotn role by remove DOM node thtat used to
have button role and using the gridcell role element for the primary
chip action instead.
Tested cross-browser with supported screen readers on MacOS and Windows.
Tested on "Chips with input" example by verifying that a chip could be
added then edited after adding. Also verifying that AT read the chip's
aria description.
Testing Environment
Fix #27106