refactor(material/autocomplete): switch to tokens API #27288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
autocomplete-tokens
branch
2 times, most recently
from
e8d372a to
32d0463
Compare
Reworks the autocomplete to use the new tokens API.
crisbeto
force-pushed
the
autocomplete-tokens
branch
from
32d0463 to
3deb18a
Compare
crisbeto
added
P3
crisbeto
commented
Jun 14, 2023
| transform-origin: center top; | ||
| overflow: auto; | ||
| padding: 8px 0; | ||
| border-radius: 4px; |
There was a problem hiding this comment.
I can see the border-radius and padding potentially being themable here, but MDC's menu surface doesn't expose tokens for them so I didn't either. We can always add custom tokens afterwards.
andrewseguin
approved these changes
Jun 14, 2023
crisbeto
added a commit
that referenced
this pull request
Jun 14, 2023
Reworks the autocomplete to use the new tokens API. (cherry picked from commit 8872c16)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the autocomplete to use the new tokens API.