-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: improved contributing and coding standard docs #27280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify the changes here? They seem to be identical to what we currently have.
Hi, @crisbeto Thanks for the comment. Yes sure, In the codinding_standard.md, I have updated the sentences according to the language tool. In summary, it is better to use "to" instead of over and instead of "all of the" to "all the". |
Which language tool? The changes seem a bit arbitrary to me. |
According to the English language for sentence creation. |
Can you share a link? |
These changes are a little arbitrary and in some cases only subjectively better. Thank you for the contribution - we would encourage more substantial changes next time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @alan-agius4 @josephperrott Could you please merge this PR? |
(cherry picked from commit 9b81cf9)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.