Skip to content

docs: improved contributing and coding standard docs #27280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

alkavats1
Copy link
Contributor

No description provided.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 12, 2023
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the changes here? They seem to be identical to what we currently have.

@devversion devversion removed their request for review June 12, 2023 11:42
@alkavats1
Copy link
Contributor Author

Can you clarify the changes here? They seem to be identical to what we currently have.

Hi, @crisbeto Thanks for the comment. Yes sure, In the codinding_standard.md, I have updated the sentences according to the language tool. In summary, it is better to use "to" instead of over and instead of "all of the" to "all the".
And in the contributing.md, I have updated the "For individual we have.." to "For individual, we have .."
It is a better way to write a sentence.
Please verify and review
Thanks :)

@crisbeto
Copy link
Member

Which language tool? The changes seem a bit arbitrary to me.

@alkavats1
Copy link
Contributor Author

According to the English language for sentence creation.

@crisbeto
Copy link
Member

Can you share a link?

@alkavats1
Copy link
Contributor Author

@andrewseguin
Copy link
Contributor

andrewseguin commented Jun 12, 2023

These changes are a little arbitrary and in some cases only subjectively better. Thank you for the contribution - we would encourage more substantial changes next time

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alkavats1
Copy link
Contributor Author

Hi @alan-agius4 @josephperrott Could you please merge this PR?
Thanks

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 14, 2023
@mmalerba mmalerba merged commit 9b81cf9 into angular:main Jun 14, 2023
mmalerba pushed a commit that referenced this pull request Jun 14, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants