Skip to content

refactor(material/chips): Use tokens for state layer #27245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Jun 6, 2023

refactor(material/chips): Use tokens for state layer

Refactors how the state layer for chips components is styled. Use the
focus-state-layer-color and focus-state-layer-opacity to style the
focus state layer.

Does not make visual changes.

Googlers: see also http://cl/538867829

@zarend zarend force-pushed the chip-token-state-layer branch 2 times, most recently from 639cdd6 to fbf0ab5 Compare June 6, 2023 22:21
@zarend zarend added Accessibility This issue is related to accessibility (a11y) area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Deployed dev-app for a806e61 to: https://ng-dev-previews-comp--pr-angular-components-27245-z21k4aue.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@zarend zarend force-pushed the chip-token-state-layer branch 3 times, most recently from 45d9eda to 9d6bfd6 Compare June 8, 2023 20:04
@zarend zarend force-pushed the chip-token-state-layer branch from 9d6bfd6 to 94d5283 Compare June 15, 2023 21:03
@zarend zarend changed the title refactor to use token for state layer refactor(material/chips): Use tokens for state layer Jun 15, 2023
@zarend zarend added the target: patch This PR is targeted for the next patch release label Jun 15, 2023
@zarend zarend force-pushed the chip-token-state-layer branch 3 times, most recently from 02560fb to 8b55472 Compare June 15, 2023 23:44
Refactors how the state layer for chips components is styled. Use the
`focus-state-layer-color` and `focus-state-layer-opacity` to style the
focus state layer.

Does not make visual changes.
@zarend zarend force-pushed the chip-token-state-layer branch from 8b55472 to a806e61 Compare June 16, 2023 17:36
@zarend zarend marked this pull request as ready for review June 16, 2023 18:46
@zarend zarend requested review from mmalerba and crisbeto as code owners June 16, 2023 18:46
@zarend zarend requested a review from andrewseguin June 16, 2023 19:05
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jun 16, 2023
@zarend zarend merged commit 3be0809 into angular:main Jun 16, 2023
zarend added a commit that referenced this pull request Jun 16, 2023
Refactors how the state layer for chips components is styled. Use the
`focus-state-layer-color` and `focus-state-layer-opacity` to style the
focus state layer.

Does not make visual changes.

(cherry picked from commit 3be0809)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants