docs(material/theming): update typography tables to be consistent #27206
+27
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the top table in the typography guide to be consistent with what's implemented and with the table further down the page. It also tweaks the second table to give greater emphasis to the class names that match the typography levels when more than one class is mapped to a style.
michaelfaith
force-pushed
the
docs/align-typography-documentation
branch
from
f5868b4 to
0113926
Compare
michaelfaith
changed the title
|
watching this carefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the top table in the typography guide to be consistent with what's implemented and with the table further down the page. I used the Scale Categories from M2's type documentation for the Descriptions, since the old descriptions were carry-overs from the pre-MDC version, and could be confusing / misleading in this context. It seemed appropriate to pull from the Material spec for these. The use of "Large body text" and "Medium body text" is meant to help bridge the gap to the eventual shift to M3, since those type levels equate to M3's Large and Medium body text, respectively.
I also tweaked the second table to give greater emphasis to the class names that match the typography levels when more than one class is mapped to a style. I removed
mat-h5andmat-h6from the second table, since they were explained in the section below the table and since they don't map directly to any type levels in the Material spec, their inclusion in this table alongsideheadline-5/6(with different meaning) could be confusing.Fixes #27112