Skip to content

docs(material/chips): require announcing removal of chip to AT #27197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented May 30, 2023

Update the accessibility instructions for the MatChipRemove directive. Require author to communicate to Assisstive Technology when a chip is removed. This can be done by sending a message with LiveAnnouncer.

Following these instructions avoids an a11y issue where removing a chip is communicated only visually, and it is not communicated with any other senses (#12122).

Update all examples to follow these instructions by announcing deletion with LiveAnnouncer.

Fix #12122

@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation target: patch This PR is targeted for the next patch release area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase labels May 30, 2023
@zarend zarend requested a review from jelbourn May 30, 2023 22:20
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-robot angular-robot bot added the area: docs Related to the documentation label May 30, 2023
@github-actions
Copy link

github-actions bot commented May 30, 2023

Deployed dev-app for 814f28e to: https://ng-dev-previews-comp--pr-angular-components-27197-z8zwt8el.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Update the accessibility instructions for the `MatChipRemove` directive.
Require author to communicate to Assisstive Technology when a chip is
removed. This can be done by sending a message with `LiveAnnouncer`.

Following these instructions avoids an a11y issue  where removing a chip is
communicated only visually, and it is not communicated with any other
senses (angular#12122).

Update all examples to follow these instructions by announcing deletion
with `LiveAnnouncer`.

Fix angular#12122
@zarend zarend force-pushed the remove-chip-a11y-docs branch from 81e84f9 to 814f28e Compare June 9, 2023 18:30
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Jun 9, 2023
@zarend zarend merged commit cddb04f into angular:main Jun 9, 2023
zarend added a commit that referenced this pull request Jun 9, 2023
Update the accessibility instructions for the `MatChipRemove` directive.
Require author to communicate to Assisstive Technology when a chip is
removed. This can be done by sending a message with `LiveAnnouncer`.

Following these instructions avoids an a11y issue  where removing a chip is
communicated only visually, and it is not communicated with any other
senses (#12122).

Update all examples to follow these instructions by announcing deletion
with `LiveAnnouncer`.

Fix #12122

(cherry picked from commit cddb04f)
@zarend zarend deleted the remove-chip-a11y-docs branch June 9, 2023 18:31
zarend added a commit that referenced this pull request Jun 9, 2023
Update the accessibility instructions for the `MatChipRemove` directive.
Require author to communicate to Assisstive Technology when a chip is
removed. This can be done by sending a message with `LiveAnnouncer`.

Following these instructions avoids an a11y issue  where removing a chip is
communicated only visually, and it is not communicated with any other
senses (#12122).

Update all examples to follow these instructions by announcing deletion
with `LiveAnnouncer`.

Fix #12122

(cherry picked from commit cddb04f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/chips dev-app preview When applied, previews of the dev-app are deployed to Firebase docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility] Screen reader doesn't announce chip removal when a chip is removed via keyboard
3 participants