refactor(material/table): switch to tokens API #27192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
force-pushed
the
table-tokens
branch
5 times, most recently
from
eeee16b to
0cbc94e
Compare
crisbeto
force-pushed
the
table-tokens
branch
3 times, most recently
from
c3bed15 to
361d616
Compare
crisbeto
commented
Jun 8, 2023
andrewseguin
approved these changes
Jun 8, 2023
| @@ -71,12 +71,21 @@ $_component-prefix: null; | |||
|
|
|||
| // Emits a slot for the given token, provided that it has a non-null value in the token map passed | |||
| // to `use-tokens`. | |||
| @mixin create-token-slot($property, $token) { | |||
| @mixin create-token-slot($property, $token, $emit-fallback: false) { | |||
There was a problem hiding this comment.
Should we comment that having emit-fallback = true would be for temporary workarounds?
mmalerba
reviewed
Jun 9, 2023
| mdc-data-table-theme.$stroke-color: rgba(mdc-theme-color.prop-value(on-surface), 0.12); | ||
|
|
||
| @include mdc-data-table.table-styles($query: mdc-helpers.$mdc-theme-styles-query); | ||
| @mixin _output-tokens { |
There was a problem hiding this comment.
I think you can use this function instead: https://github.com/angular/components/blob/main/src/material/core/style/_sass-utils.scss#L11
Also, I'm not sure we need to clean it up, I'd like to move toward emitting the tokens under the user's selector (or document root if they don't specify one)
Reworks the Material table to use the new tokens API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the Material table to use the new tokens API.