Skip to content

docs: convert examples to standalone #27137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023

Conversation

crisbeto
Copy link
Member

Converts all of the Components examples to standalone to reduce the amount of boilerplate we need to maintain and to simplify the Stackblitz.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 22, 2023
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 22, 2023
@crisbeto crisbeto force-pushed the standalone-examples branch 3 times, most recently from 12a94c5 to 06b727f Compare May 22, 2023 12:26
@crisbeto crisbeto marked this pull request as ready for review May 22, 2023 12:30
@crisbeto crisbeto assigned crisbeto and unassigned crisbeto May 22, 2023
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment.

Note that I didn't fully check every example and their imports (just to capture this)

@@ -19,19 +19,8 @@ export interface LiveExample {
packagePath: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at some point we should clean up the file name then.

Converts all of the Components examples to standalone to reduce the amount of boilerplate we need to maintain and to simplify the Stackblitz.
@crisbeto crisbeto force-pushed the standalone-examples branch from 06b727f to 510ed50 Compare May 22, 2023 13:21
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 22, 2023
@angular-robot angular-robot bot merged commit 748f177 into angular:main May 22, 2023
angular-robot bot pushed a commit that referenced this pull request May 22, 2023
Converts all of the Components examples to standalone to reduce the amount of boilerplate we need to maintain and to simplify the Stackblitz.

(cherry picked from commit 748f177)
@jeffschulzusc
Copy link

hi ...

do you know what is status of:
https://github.com/angular/components/tree/main/src/components-examples/material-experimental/column-resize/opt-in-column-resize

i gave it a try but it seems does not work ... i don't see any col-resize cursor or other on my table columns

thanks much

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants