Skip to content

fix(cdk/schematics): handle templates with byte order mark #27131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2023
Merged

fix(cdk/schematics): handle templates with byte order mark #27131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/schematics/update-tool/component-resource-collector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class ComponentResourceCollector {
return;
}

const fileContent = this._fileSystem.read(templatePath);
const fileContent = stripBom(this._fileSystem.read(templatePath) || '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi: need to be very careful here. It depends on the virtual tree and update recorder, whether they auto-insert the BOM offset or not. I just remember some issues there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it would be okay since it fixed the error and we've had that call for CSS files for a long time now.


if (fileContent) {
const lineStartsMap = computeLineStartsMap(fileContent);
Expand Down