build: create ng add integration test using ng new #27096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
May 15, 2023
|
|
||
| # Generate a new project with the default options. | ||
| # Skip installation since we installed the dependencies already. | ||
| "yarn ng new --defaults --skip-install --style=scss --name=%s" % APP_NAME, |
There was a problem hiding this comment.
In the future, potentially we can make this a shared script if we end up duplicating these steps multiple times.
Reworks the `ng add` integration test to run `ng new` first which should make it easier to keep up with changes to the project layout.
crisbeto
force-pushed
the
ng-add-integration-rework
branch
from
a2aa5c1 to
6546f3f
Compare
angular-robot bot
pushed a commit
that referenced
this pull request
May 15, 2023
Reworks the `ng add` integration test to run `ng new` first which should make it easier to keep up with changes to the project layout. (cherry picked from commit 1546b3f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the
ng addintegration test to runng newfirst which should make it easier to keep up with changes to the project layout.