fix(material/paginator): add aria-hidden="true" to decorative svg's #27083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the mat-paginator component, add aria-hidden="true" to the decorative svg elements. Previously, the svg elements for the chevron icons would produce an img node in the a11y tree nested under the button node for "Previous page"/"Next page". This seemed to cause issue with JAWS screenreader where screen reader navigation would have duplicate navigation (angular#26967). With this change applied, the svg elements are aria-hidden and do not affect the accessibility tree. This is appripriate since the chevron icons are purely decorative. Fix angular#26967
zarend
added
Accessibility
|
Deployed dev-app for 354cc21 to: https://ng-dev-previews-comp--pr-angular-components-27083-uabwe8ml.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
angular-robot bot
pushed a commit
that referenced
this pull request
May 15, 2023
…27083) For the mat-paginator component, add aria-hidden="true" to the decorative svg elements. Previously, the svg elements for the chevron icons would produce an img node in the a11y tree nested under the button node for "Previous page"/"Next page". This seemed to cause issue with JAWS screenreader where screen reader navigation would have duplicate navigation (#26967). With this change applied, the svg elements are aria-hidden and do not affect the accessibility tree. This is appripriate since the chevron icons are purely decorative. Fix #26967 (cherry picked from commit a3250c3)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 7, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`16.0.1` -> `16.0.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/16.0.1/16.0.3) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`16.0.1` -> `16.0.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/16.0.1/16.0.3) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v16.0.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1603-silk-scarf-2023-06-01) [Compare Source](angular/components@16.0.2...16.0.3) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [3d4a9d1607](angular/components@3d4a9d1) | fix | **overlay:** remove circular dependency workarounds ([#​27190](angular/components#27190)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [c8065d5168](angular/components@c8065d5) | fix | **chips:** fix click target when stacked ([#​27129](angular/components#27129)) | | [12e47478c5](angular/components@12e4747) | fix | **slider:** handle ngModel initial null value ([#​27149](angular/components#27149)) | <!-- CHANGELOG SPLIT MARKER --> ### [`v16.0.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1602-plastic-car-2023-05-25) [Compare Source](angular/components@16.0.1...16.0.2) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [a0aa14fe1a](angular/components@a0aa14f) | fix | **schematics:** handle templates with byte order mark ([#​27131](angular/components#27131)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [82550af4d7](angular/components@82550af) | fix | **checkbox:** set token values on the element where theme is [@​included](https://github.com/included) ([#​27114](angular/components#27114)) | | [d2e8a55b3b](angular/components@d2e8a55) | fix | **core:** Fix MacOS Hover feature compatibility with optgroup ([#​27081](angular/components#27081)) | | [6dd2c605b1](angular/components@6dd2c60) | fix | **datepicker:** set explicit event options ([#​27082](angular/components#27082)) | | [5c3107ccc6](angular/components@5c3107c) | fix | **icon:** harness returning wrong name if icon has other content ([#​27132](angular/components#27132)) | | [9d9ceb2b22](angular/components@9d9ceb2) | fix | **list:** input coercion does not working for `disableRipple` on list items ([#​27126](angular/components#27126)) | | [5aad5df78e](angular/components@5aad5df) | fix | **paginator:** add aria-hidden="true" to decorative svg's ([#​27083](angular/components#27083)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [12474aafc5](angular/components@12474aa) | fix | set aria-hidden on presentational svgs ([#​27116](angular/components#27116)) | <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTEuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1918 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the mat-paginator component, add aria-hidden="true" to the decorative svg elements.
Previously, the svg elements for the chevron icons would produce an img node in the a11y tree nested under the button node for "Previous page"/"Next page". This seemed to cause issue with JAWS screenreader where screen reader navigation would have duplicate navigation (#26967).
With this change applied, the svg elements are aria-hidden and do not affect the accessibility tree. This is appripriate since the chevron icons are purely decorative.
Fix #26967