build: add a generated helper function to load examples #26968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new helper removes the examples' reliance on internal APF structure and naming. Currently the examples hard code the ECMAScript version into the application which can and will change over time. The helper function also removes the need to use Webpack-specific magic comments in the documentation website to prevent unwanted files from being loaded. The recent updates to the APF for v16 required several manual changes to both the examples and the documentation site which will no longer be needed in the future. This change retains the existing functionality to allow for the documentation site to be updated with the new functionality. Once updated, additional cleanup is possible to remove the then unused loading functionality.
angular-robot
bot
added
the
area: build & ci
clydin
added
the
action: review
crisbeto
reviewed
Apr 21, 2023
clydin
added
action: merge
angular-robot bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
* build: add a generated helper function to load examples This new helper removes the examples' reliance on internal APF structure and naming. Currently the examples hard code the ECMAScript version into the application which can and will change over time. The helper function also removes the need to use Webpack-specific magic comments in the documentation website to prevent unwanted files from being loaded. The recent updates to the APF for v16 required several manual changes to both the examples and the documentation site which will no longer be needed in the future. This change retains the existing functionality to allow for the documentation site to be updated with the new functionality. Once updated, additional cleanup is possible to remove the then unused loading functionality. * fixup! build: add a generated helper function to load examples (cherry picked from commit 524c243)
clydin
added a commit
to clydin/material.angular.io
that referenced
this pull request
Apr 21, 2023
Loading the Material examples now uses the newly provide `loadExample` helper function and avoids the need to manually specify APF directory structures which can change as new ECMAScript versions are used. Components PR: angular/components#26968
clydin
added a commit
to clydin/material.angular.io
that referenced
this pull request
Apr 21, 2023
Loading the Material examples now uses the newly provide `loadExample` helper function and avoids the need to manually specify APF directory structures which can change as new ECMAScript versions are used. Components PR: angular/components#26968
clydin
added a commit
to clydin/material.angular.io
that referenced
this pull request
Apr 21, 2023
Loading the Material examples now uses the newly provide `loadExample` helper function and avoids the need to manually specify APF directory structures which can change as new ECMAScript versions are used. Components PR: angular/components#26968
clydin
added a commit
to clydin/material.angular.io
that referenced
this pull request
Apr 21, 2023
Loading the Material examples now uses the newly provide `loadExample` helper function and avoids the need to manually specify APF directory structures which can change as new ECMAScript versions are used. Components PR: angular/components#26968
devversion
pushed a commit
to angular/material.angular.io
that referenced
this pull request
Apr 21, 2023
Loading the Material examples now uses the newly provide `loadExample` helper function and avoids the need to manually specify APF directory structures which can change as new ECMAScript versions are used. Components PR: angular/components#26968
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new helper removes the examples' reliance on internal APF structure and naming. Currently the examples hard code the ECMAScript version into the application which can and will change over time. The helper function also removes the need to use Webpack-specific magic comments in the documentation website to prevent unwanted files from being loaded.
The recent updates to the APF for v16 required several manual changes to both the examples and the documentation site which will no longer be needed in the future. This change retains the existing functionality to allow for the documentation site to be updated with the new functionality. Once updated, additional cleanup is possible to remove the then unused loading functionality.