fix(material/form-field): inconsistent height for non-text inputs #26941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
devversion
approved these changes
Apr 17, 2023
| @@ -20,6 +20,36 @@ | |||
| border: none; | |||
| } | |||
|
|
|||
| .mat-mdc-form-field-input-control { | |||
There was a problem hiding this comment.
Are we overriding MDC styles here, or overriding native styles? If so, this file/mixin is only for MDC overrides
There was a problem hiding this comment.
It's overriding user agent styles. Where would the styles go in that case? form-field.scss?
There was a problem hiding this comment.
I thought we already had something, but couldn't find it. Maybe another file? like user-agent-overrides? (whatever you prefer here)
crisbeto
force-pushed
the
26915/form-field-input-types
branch
from
ea70ca6 to
21d39b3
Compare
devversion
approved these changes
Apr 17, 2023
crisbeto
force-pushed
the
26915/form-field-input-types
branch
2 times, most recently
from
9fd0bb8 to
8dcdad2
Compare
Fixes that some non-text input variants were taller than the text ones. Fixes angular#26915.
crisbeto
force-pushed
the
26915/form-field-input-types
branch
from
8dcdad2 to
3922d70
Compare
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Apr 28, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.6` -> `15.2.8`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.6/15.2.8) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.6` -> `15.2.8`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.6/15.2.8) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.2.8`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1528-nickel-nickel-2023-04-19) [Compare Source](angular/components@15.2.7...15.2.8) ##### material | Commit | Type | Description | | -- | -- | -- | | [af293a124](angular/components@af293a1) | fix | **core:** remove tabindex from mat-option ([#​26917](angular/components#26917)) | | [5623a8c8b](angular/components@5623a8c) | fix | **form-field:** inconsistent height for non-text inputs ([#​26941](angular/components#26941)) | <!-- CHANGELOG SPLIT MARKER --> ### [`v15.2.7`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1527-paper-pelican-2023-04-13) [Compare Source](angular/components@15.2.6...15.2.7) ##### material | Commit | Type | Description | | -- | -- | -- | | [de22cdc72](angular/components@de22cdc) | fix | **table:** correct filterPredicate typo ([#​26902](angular/components#26902)) | ##### material-luxon-adapter | Commit | Type | Description | | -- | -- | -- | | [6c00403a8](angular/components@6c00403) | fix | zone on DateTime ignored ([#​26887](angular/components#26887)) | <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzUuNjEuMCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1865 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that some non-text input variants were taller than the text ones.
Fixes #26915.