Skip to content

refactor: remove @angular/compiler/testing #26940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Apr 15, 2023

@angular/compiler/testing was emptied in angular#34884 for v13.1.

It's the only place I found it used in components.

Can you confirm ?

@JeanMeche JeanMeche force-pushed the chore/compiler-testing branch from 6a922ad to cba5ba0 Compare April 15, 2023 16:53
@JeanMeche JeanMeche marked this pull request as draft April 15, 2023 16:53
@JeanMeche JeanMeche marked this pull request as ready for review April 15, 2023 17:06
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Apr 16, 2023
@angular-robot angular-robot bot merged commit a199ab4 into angular:main Apr 16, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants