Skip to content

refactor(material/core): generalize lazy ripple logic #26897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2023
Merged

refactor(material/core): generalize lazy ripple logic #26897

merged 5 commits into from
Jun 12, 2023

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel marked this pull request as ready for review April 7, 2023 21:51
josephperrott
josephperrott requested changes Apr 10, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But this should be marked as a brekaing change, and can't land until next major period.

@wagnermaciel wagnermaciel added target: major This PR is targeted for the next major release detected: breaking change PR contains a commit with a breaking change labels Apr 10, 2023
@angular-robot angular-robot bot removed the detected: breaking change PR contains a commit with a breaking change label Apr 11, 2023
@devversion devversion removed their request for review April 11, 2023 14:42
@wagnermaciel wagnermaciel requested a review from jelbourn as a code owner April 13, 2023 16:56
@wagnermaciel wagnermaciel requested a review from mmalerba May 18, 2023 16:21
mmalerba
mmalerba reviewed Jun 1, 2023
View reviewed changes
@wagnermaciel wagnermaciel requested a review from mmalerba June 2, 2023 16:08
mmalerba
mmalerba approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release labels Jun 9, 2023
@wagnermaciel wagnermaciel added the detected: breaking change PR contains a commit with a breaking change label Jun 12, 2023
josephperrott
josephperrott approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel removed the detected: breaking change PR contains a commit with a breaking change label Jun 12, 2023
@wagnermaciel wagnermaciel merged commit 18400e7 into angular:main Jun 12, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wagnermaciel @josephperrott @mmalerba