Skip to content

docs(material/form-field): custom MatFormFieldControl validation not … #26873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Captainnik53
Copy link
Contributor

…working unless touched

Fixes a bug in the Angular Material Guide where form-control remains valid unless touched. This is because MatFormFieldControl emits null value when form is invalid, but default value was not set to null, bypassing required Validators.

Fixes #23352

…working unless touched

Fixes a bug in the Angular Material  where form-control remains valid unless touched. This is because MatFormFieldControl emits null value when form is invalid, but default value was not set to null, bypassing required Validators.

Fixes angular#23352
@angular-robot angular-robot bot added the area: docs Related to the documentation label Apr 1, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 28, 2024
@crisbeto crisbeto self-assigned this Feb 28, 2024
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 28, 2024
@crisbeto crisbeto removed the request for review from andrewseguin February 28, 2024 09:14
@crisbeto crisbeto merged commit 76b4ea1 into angular:main Feb 28, 2024
crisbeto pushed a commit that referenced this pull request Feb 28, 2024
…working unless touched (#26873)

Fixes a bug in the Angular Material  where form-control remains valid unless touched. This is because MatFormFieldControl emits null value when form is invalid, but default value was not set to null, bypassing required Validators.

Fixes #23352

(cherry picked from commit 76b4ea1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(mat-form-field): required does not work in the custom form field control guide
2 participants