Change the throw in line 186 from string to error #26736

RuoJia123 · 2023-03-06T23:59:15Z

No description provided.

mmalerba

LGTM

(cherry picked from commit 7043a51)

…isplay a label from its start (angular#26736)

…isplay a label from its start (#26736) (#26737)

…isplay a label from its start (#26736) (#26737) (cherry picked from commit 946cc67)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.1/15.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.1` -> `15.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.1/15.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1525-metal-plumber-2023-03-29) [Compare Source](angular/components@15.2.4...15.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [4ec3abd723](angular/components@4ec3abd) | fix | **overlay:** don't close if scroll is coming from inside overlay ([#26840](angular/components#26840)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [600d40eb24](angular/components@600d40e) | fix | **datepicker:** remove div as a child of button ([#26838](angular/components#26838)) | #### Special Thanks Kristiyan Kostadinov and Wagner Maciel  ### [`v15.2.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1524-brimstone-bank-2023-03-23) [Compare Source](angular/components@15.2.3...15.2.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [580fbf500](angular/components@580fbf5) | fix | **core:** apply strong focus styles to selected option ([#26811](angular/components#26811)) | | [1ba5ade41](angular/components@1ba5ade) | fix | **datepicker:** date range input not marked as required when using reactive forms ([#26749](angular/components#26749)) | | [acc7d8148](angular/components@acc7d81) | fix | **tooltip:** only expand hover area on side closest to trigger ([#26786](angular/components#26786)) | #### Special Thanks Kristiyan Kostadinov, Wagner Maciel and Zach Arend  ### [`v15.2.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1523-aluminum-statue-2023-03-16) [Compare Source](angular/components@15.2.2...15.2.3) ##### material | Commit | Type | Description | | -- | -- | -- | | [7dfcf8ff3](angular/components@7dfcf8f) | fix | **checkbox:** fix ARIA semantics and use native DOM properties ([#26710](angular/components#26710)) | | [40d38889c](angular/components@40d3888) | fix | **chips:** chip label appearing above sticky columns ([#26794](angular/components#26794)) | | [b846d1e05](angular/components@b846d1e) | fix | **chips:** don't prevent default mousedown action ([#26765](angular/components#26765)) | | [501d73e5b](angular/components@501d73e) | fix | **chips:** styling not cleared on basic chips in listbox and grid ([#26771](angular/components#26771)) | | [06ed54c25](angular/components@06ed54c) | fix | **tabs:** update MatTab \_scrollToLabel function to always display a label from its start ([#26736](angular/components#26736)) ([#26737](angular/components#26737)) | #### Special Thanks Boyi Li, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend  ### [`v15.2.2`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#1522-topaz-toast-2023-03-08) [Compare Source](angular/components@15.2.1...15.2.2) ##### material | Commit | Type | Description | | -- | -- | -- | | [e7612c747](angular/components@e7612c7) | fix | **chips:** unable to shift + tab out of a chip set ([#26727](angular/components#26727)) | | [1bf2fc2e1](angular/components@1bf2fc2) | fix | **core:** mat-option sets aria-selected="false" ([#26673](angular/components#26673)) | | [9473b1688](angular/components@9473b16) | fix | **datepicker:** resolve server-side rendering error ([#26742](angular/components#26742)) | | [99dac0835](angular/components@99dac08) | fix | **paginator:** opt-out of single-selection indicator ([#26746](angular/components#26746)) | | [ec824f1f7](angular/components@ec824f1) | fix | **snack-bar:** live region not working when modal is open ([#26725](angular/components#26725)) | ##### cdk-experimental | Commit | Type | Description | | -- | -- | -- | | [e1c8fe85b](angular/components@e1c8fe8) | fix | **scrolling:** throw error rather than string ([#26736](angular/components#26736)) | #### Special Thanks Kristiyan Kostadinov, RuoJia123 and Zach Arend  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1813 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-04-07T00:08:51Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Change the throw in line 186 from string to error

c66d34d

RuoJia123 requested a review from mmalerba as a code owner March 6, 2023 23:59

mmalerba added action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Mar 7, 2023

mmalerba approved these changes Mar 7, 2023

View reviewed changes

mmalerba added the target: patch This PR is targeted for the next patch release label Mar 7, 2023

angular-robot bot merged commit 7043a51 into angular:main Mar 7, 2023

angular-robot bot pushed a commit that referenced this pull request Mar 7, 2023

fix(cdk-experimental/scrolling): throw error rather than string (#26736)

e1c8fe8

(cherry picked from commit 7043a51)

gregmagolan mentioned this pull request Mar 8, 2023

Import material.angular.io aspect-forks/components#2

Closed

clamli added a commit to clamli/components that referenced this pull request Mar 8, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

f38c679

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 8, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

62479a2

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 8, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

824dd84

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 8, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

a47c834

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 9, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

892f69e

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 9, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

08ff9c1

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 9, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

c473a3c

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 9, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

0fdf334

…isplay a label from its start (angular#26736)

clamli added a commit to clamli/components that referenced this pull request Mar 9, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

ce2f8f4

…isplay a label from its start (angular#26736)

crisbeto pushed a commit that referenced this pull request Mar 15, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

946cc67

…isplay a label from its start (#26736) (#26737)

crisbeto pushed a commit that referenced this pull request Mar 15, 2023

fix(material/tabs): update MatTab _scrollToLabel function to always d…

06ed54c

…isplay a label from its start (#26736) (#26737) (cherry picked from commit 946cc67)

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 7, 2023

andrewseguin assigned mmalerba Jun 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change the throw in line 186 from string to error #26736

Change the throw in line 186 from string to error #26736

Uh oh!

RuoJia123 commented Mar 6, 2023

Uh oh!

mmalerba left a comment

Uh oh!

angular-automatic-lock-bot bot commented Apr 7, 2023

Uh oh!

Uh oh!

Change the throw in line 186 from string to error #26736

Change the throw in line 186 from string to error #26736

Uh oh!

Conversation

RuoJia123 commented Mar 6, 2023

Uh oh!

mmalerba left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Apr 7, 2023

Uh oh!

Uh oh!