refactor(cdk/a11y): restrict setAttribute fanout capability #26503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By restricting the type of the parameter of `addAriaReferencedId`, make sure it only sets `aria-` attributes.
devversion
approved these changes
Jan 26, 2023
devversion
added
action: merge
angular-robot bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
By restricting the type of the parameter of `addAriaReferencedId`, make sure it only sets `aria-` attributes. (cherry picked from commit 1551d52)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By restricting the type of the parameter of
addAriaReferencedId, make sure it only setsaria-attributes.This makes it easier for Google security reviewers to reason about the safety of the code, granting the confidence that it will never set any security-sensitive attribute.