Skip to content

build: adjust peer dependency to include all minor pre-releases #26421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

devversion
Copy link
Member

Pre-release versions of Angular Material should be compatible with the same pre-release versions of FW (being worked on at the same time).

Additionally we want to expand the peer dependency so that the pre-release Material version is also compatible future pre-release of framework. e.g. consider the scenario where Angular framework already released 15.2.0-next.0, while both CLI and COMP are still on 15.1.0-next.0.

CLI in this case want to depend on the latest
versions, but with the recent stricter NPM version this would break as Material wouldn't allow v15.2.0-next.0

We switch to a more simpler model that requires less changes by the caretaker. For @next releases we will be more flexible and allow for all pre-releases of the current major and (N+1)-next/rc

Also we no longer require the peer dep to be updated manually.

This simplifies the caretaker experience as the peer dependency would no longer need to be updated manually every time the release version changes.

Pre-release versions of Angular Material should be compatible with
the same pre-release versions of FW (being worked on at the same time).

Additionally we want to expand the peer dependency so that the
pre-release Material version is also compatible future pre-release
of framework. e.g. consider the scenario where Angular framework
already released `15.2.0-next.0`, while both CLI and COMP are still
on `15.1.0-next.0`.

CLI in this case want to depend on the latest
versions, but with the recent stricter NPM version this would break
as Material wouldn't allow `v15.2.0-next.0`

We switch to a more simpler model that requires less changes by
the caretaker. For `@next` releases we will be more flexible and
allow for all pre-releases of the current major and (N+1)-next/rc

Also we no longer require the peer dep to be updated manually.

This simplifies the caretaker experience as the peer dependency
would no longer need to be updated manually every time the
release version changes.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 12, 2023
@devversion devversion added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 12, 2023
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 12, 2023
@devversion devversion merged commit 6afe888 into angular:main Jan 12, 2023
devversion added a commit that referenced this pull request Jan 12, 2023
Pre-release versions of Angular Material should be compatible with
the same pre-release versions of FW (being worked on at the same time).

Additionally we want to expand the peer dependency so that the
pre-release Material version is also compatible future pre-release
of framework. e.g. consider the scenario where Angular framework
already released `15.2.0-next.0`, while both CLI and COMP are still
on `15.1.0-next.0`.

CLI in this case want to depend on the latest
versions, but with the recent stricter NPM version this would break
as Material wouldn't allow `v15.2.0-next.0`

We switch to a more simpler model that requires less changes by
the caretaker. For `@next` releases we will be more flexible and
allow for all pre-releases of the current major and (N+1)-next/rc

Also we no longer require the peer dep to be updated manually.

This simplifies the caretaker experience as the peer dependency
would no longer need to be updated manually every time the
release version changes.

(cherry picked from commit 6afe888)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants