docs(cdk/listbox): fix a11y of example #26014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Nov 18, 2022
| @@ -1,7 +1,9 @@ | |||
| <form> | |||
| <p> | |||
| <input type="checkbox" [formControl]="canDrinkCtrl"> | |||
| <label>I am 21 or older</label> | |||
| <label> | |||
There was a problem hiding this comment.
I think the correct fix would be to set a for attribute on the label.
There was a problem hiding this comment.
I saw both usages in the repo, but sure. I'm gonna chang it for id="can-drink" as in the checkbox-demo.html.
Totati
force-pushed
the
Totati/issue26003
branch
from
4204f9a to
7548bf8
Compare
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Nov 18, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26003