-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/list): pointer events disabled around content #26012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MDC applies `pointer-events: none` around different sections of the list item which breaks interactivity. As evidenced by the dev app demos, we support interactive content in them so these changes reset the `pointer-events` back to `auto`. Fixes angular#26010.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
// even though we allowed interactive content in them. | ||
.mdc-list-item__start, | ||
.mdc-list-item__end, | ||
.mdc-list-item__content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking: Should content allow for pointer-events:none? I don't fully recall without looking, but might be needed for anchor elements and disabling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MDC's code doesn't have any comments on why the pointer-events: none
is there. I don't think that it's there for anchor list items that are disabled, because it's only a wrapper around the projected content. My best guess is that it's used as a shorthand to switch the cursor to the default and disable text selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the quick fix. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
MDC applies
pointer-events: none
around different sections of the list item which breaks interactivity. As evidenced by the dev app demos, we support interactive content in them so these changes reset thepointer-events
back toauto
.Fixes #26010.