Skip to content

fix(material/form-field): don't block click on prefix/suffix when disabled #25987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix(material/form-field): don't block click on prefix/suffix when disabled #25987

merged 1 commit into from
Nov 18, 2022

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 16, 2022 •
edited
Loading

fixes #25986

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 16, 2022
@mmalerba mmalerba requested a review from devversion as a code owner November 16, 2022 00:52
crisbeto
crisbeto reviewed Nov 16, 2022
View reviewed changes
devversion
devversion approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think Kristiyan's suggestion is worth considering

crisbeto
crisbeto approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2022
@mmalerba mmalerba merged commit c08e3f1 into angular:main Nov 18, 2022
mmalerba added a commit that referenced this pull request Nov 18, 2022
@mmalerba
fix(material/form-field): don't block click on prefix/suffix when dis…
16ae0be 
…abled (#25987)

(cherry picked from commit c08e3f1)
@mmalerba mmalerba mentioned this pull request Dec 9, 2022
Closed
1 task
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(material/form-field): prefix/suffix of disabled form-field cannot be clicked
3 participants
@mmalerba @crisbeto @devversion